Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 28929e4b authored by Rachel Lee's avatar Rachel Lee Committed by Android (Google) Code Review
Browse files

Revert "Add new ASurfaceTransaction _setFrameRateParams API" 

Revert submission 30112724-asurfacetransaction-setframerateparams

Reason for revert: removing API to be landed in another release.

Reverted changes: /q/submissionid:30112724-asurfacetransaction-setframerateparams

Change-Id: I0750ac25a0371f6becc1e99297de8c7f77940bdf
parent ba2f3e93

native/android/libandroid.map.txt

+0 −1
Original line number Diff line number Diff line
@@ -283,7 +283,6 @@ LIBANDROID { 
    ASurfaceTransaction_setEnableBackPressure; # introduced=31

    ASurfaceTransaction_setFrameRate; # introduced=30

    ASurfaceTransaction_setFrameRateWithChangeStrategy; # introduced=31

    ASurfaceTransaction_setFrameRateParams; # introduced=36

    ASurfaceTransaction_clearFrameRate; # introduced=34

    ASurfaceTransaction_setFrameTimeline; # introduced=Tiramisu

    ASurfaceTransaction_setGeometry; # introduced=29

native/android/surface_control.cpp

+0 −22
Original line number Diff line number Diff line
@@ -731,28 +731,6 @@ void ASurfaceTransaction_setFrameRateWithChangeStrategy(ASurfaceTransaction* aSu 
    transaction->setFrameRate(surfaceControl, frameRate, compatibility, changeFrameRateStrategy);

}



void ASurfaceTransaction_setFrameRateParams(

        ASurfaceTransaction* aSurfaceTransaction, ASurfaceControl* aSurfaceControl,

        float desiredMinRate, float desiredMaxRate, float fixedSourceRate,

        ANativeWindow_ChangeFrameRateStrategy changeFrameRateStrategy) {

    CHECK_NOT_NULL(aSurfaceTransaction);

    CHECK_NOT_NULL(aSurfaceControl);

    Transaction* transaction = ASurfaceTransaction_to_Transaction(aSurfaceTransaction);

    sp<SurfaceControl> surfaceControl = ASurfaceControl_to_SurfaceControl(aSurfaceControl);



    if (desiredMaxRate < desiredMinRate) {

        ALOGW("desiredMaxRate must be greater than or equal to desiredMinRate");

        return;

    }

    // TODO(b/362798998): Fix plumbing to send modern params

    int compatibility = fixedSourceRate == 0 ? ANATIVEWINDOW_FRAME_RATE_COMPATIBILITY_DEFAULT

                                             : ANATIVEWINDOW_FRAME_RATE_COMPATIBILITY_FIXED_SOURCE;

    double frameRate = compatibility == ANATIVEWINDOW_FRAME_RATE_COMPATIBILITY_FIXED_SOURCE

            ? fixedSourceRate

            : desiredMinRate;

    transaction->setFrameRate(surfaceControl, frameRate, compatibility, changeFrameRateStrategy);

}



void ASurfaceTransaction_clearFrameRate(ASurfaceTransaction* aSurfaceTransaction,

                                        ASurfaceControl* aSurfaceControl) {

    CHECK_NOT_NULL(aSurfaceTransaction);