Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23e76188 authored by Caitlin Cassidy's avatar Caitlin Cassidy
Browse files

[Status Bar Refactor] 3/3: Inject StatusBarWindowView instead of having the 

controller construct it.

This will allow us to pass in a fake view for testing the controller.

This CL also moves the window view and controller into its own package
for slightly better organization.

Fixes: 204583449
Test: atest SystemUITests
Test: manual once-over of key user journeys
Change-Id: I4c2cc3f0c3a18466b2d1a1012c999f530329d3f7
parent 5038891a

packages/SystemUI/res/layout/super_status_bar.xml

+2 −2
Original line number Diff line number Diff line
@@ -18,7 +18,7 @@ 
-->



<!-- This is the status bar window. -->

<com.android.systemui.statusbar.phone.StatusBarWindowView

<com.android.systemui.statusbar.window.StatusBarWindowView

    xmlns:android="http://schemas.android.com/apk/res/android"

    xmlns:sysui="http://schemas.android.com/apk/res-auto"

    android:layout_width="match_parent"
@@ -35,4 +35,4 @@ 
        android:layout_width="match_parent"

        android:layout_height="wrap_content"

        android:background="@drawable/system_bar_background" />

</com.android.systemui.statusbar.phone.StatusBarWindowView>
 
</com.android.systemui.statusbar.window.StatusBarWindowView>

packages/SystemUI/src/com/android/systemui/Dependency.java

+1 −1
Original line number Diff line number Diff line
@@ -105,7 +105,6 @@ import com.android.systemui.statusbar.phone.NotificationGroupAlertTransferHelper 
import com.android.systemui.statusbar.phone.ShadeController;

import com.android.systemui.statusbar.phone.StatusBarContentInsetsProvider;

import com.android.systemui.statusbar.phone.StatusBarIconController;

import com.android.systemui.statusbar.phone.StatusBarWindowController;

import com.android.systemui.statusbar.phone.UnlockedScreenOffAnimationController;

import com.android.systemui.statusbar.policy.AccessibilityController;

import com.android.systemui.statusbar.policy.AccessibilityManagerWrapper;
@@ -129,6 +128,7 @@ import com.android.systemui.statusbar.policy.SmartReplyConstants; 
import com.android.systemui.statusbar.policy.UserInfoController;

import com.android.systemui.statusbar.policy.UserSwitcherController;

import com.android.systemui.statusbar.policy.ZenModeController;

import com.android.systemui.statusbar.window.StatusBarWindowController;

import com.android.systemui.telephony.TelephonyListenerManager;

import com.android.systemui.tracing.ProtoTracer;

import com.android.systemui.tuner.TunablePadding.TunablePaddingService;

packages/SystemUI/src/com/android/systemui/dagger/SystemUIModule.java

+2 −0
Original line number Diff line number Diff line
@@ -70,6 +70,7 @@ import com.android.systemui.statusbar.policy.HeadsUpManager; 
import com.android.systemui.statusbar.policy.ZenModeController;

import com.android.systemui.statusbar.policy.dagger.SmartRepliesInflationModule;

import com.android.systemui.statusbar.policy.dagger.StatusBarPolicyModule;

import com.android.systemui.statusbar.window.StatusBarWindowModule;

import com.android.systemui.tuner.dagger.TunerModule;

import com.android.systemui.user.UserModule;

import com.android.systemui.util.concurrency.SysUIConcurrencyModule;
@@ -110,6 +111,7 @@ import dagger.Provides; 
            SettingsUtilModule.class,

            SmartRepliesInflationModule.class,

            StatusBarPolicyModule.class,

            StatusBarWindowModule.class,

            SysUIConcurrencyModule.class,

            TunerModule.class,

            UserModule.class,

packages/SystemUI/src/com/android/systemui/qs/QuickStatusBarHeader.java

+1 −1
Original line number Diff line number Diff line
@@ -40,10 +40,10 @@ import com.android.systemui.R; 
import com.android.systemui.battery.BatteryMeterView;

import com.android.systemui.qs.QSDetail.Callback;

import com.android.systemui.statusbar.phone.StatusBarIconController.TintedIconManager;

import com.android.systemui.statusbar.phone.StatusBarWindowView;

import com.android.systemui.statusbar.phone.StatusIconContainer;

import com.android.systemui.statusbar.policy.Clock;

import com.android.systemui.statusbar.policy.VariableDateView;

import com.android.systemui.statusbar.window.StatusBarWindowView;



import java.util.List;

packages/SystemUI/src/com/android/systemui/statusbar/dagger/StatusBarDependenciesModule.java

+3 −1
Original line number Diff line number Diff line
@@ -67,11 +67,13 @@ import com.android.systemui.statusbar.phone.StatusBar; 
import com.android.systemui.statusbar.phone.StatusBarIconController;

import com.android.systemui.statusbar.phone.StatusBarIconControllerImpl;

import com.android.systemui.statusbar.phone.StatusBarRemoteInputCallback;

import com.android.systemui.statusbar.phone.StatusBarWindowController;

import com.android.systemui.statusbar.phone.SystemUIHostDialogProvider;

import com.android.systemui.statusbar.phone.ongoingcall.OngoingCallController;

import com.android.systemui.statusbar.phone.ongoingcall.OngoingCallLogger;

import com.android.systemui.statusbar.policy.RemoteInputUriController;

import com.android.systemui.statusbar.window.StatusBarWindowController;

import com.android.systemui.statusbar.window.StatusBarWindowModule;

import com.android.systemui.statusbar.window.StatusBarWindowView;

import com.android.systemui.tracing.ProtoTracer;

import com.android.systemui.util.concurrency.DelayableExecutor;

import com.android.systemui.util.time.SystemClock;