Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23d27966 authored by Garfield Tan's avatar Garfield Tan
Browse files

Stop skipping 2 methods in config changes 

To avoid duplicate configuration pushes Task introduced an override
onConfigurationChanged() method, which effectively bypassed 2 method
calls in WindowContainer#onConfigurationChanged(), and broke letterbox.

Stop bypassing those methods by overriding a different
onConfigurationChanges().

Bug: None
Test: Letterbox works.
Test: atest PinnedStackTests#testEnterPictureInPictureSavePosition
Change-Id: I66f000d5402e3a340e365e751be4df9eb765a452
parent 5c0974b2

services/core/java/com/android/server/wm/Task.java

+3 −3
Original line number Diff line number Diff line
@@ -120,12 +120,12 @@ class Task extends WindowContainer<ActivityRecord> implements ConfigurationConta 


    // TODO: Remove after unification.

    @Override

    public void onConfigurationChanged(Configuration newParentConfig) {

    public void onConfigurationChanged(Configuration newParentConfig, boolean forwardToChildren) {

        // Forward configuration changes in cases

        // - children won't get it from TaskRecord

        // - it's a pinned task

        onConfigurationChanged(newParentConfig,

                (mTaskRecord == null) || inPinnedWindowingMode() /*forwardToChildren*/);

        forwardToChildren &= (mTaskRecord == null) || inPinnedWindowingMode();

        super.onConfigurationChanged(newParentConfig, forwardToChildren);

    }



    Task(int taskId, TaskStack stack, int userId, WindowManagerService service, int resizeMode,