Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23cdee3f authored by Lais Andrade's avatar Lais Andrade
Browse files

Stop using escape HTML on SoundPicker title from intent 

The method affects non-ascii characters from the string, but it might not be necessary to prevent injecting style into the window title.

Using a String instead of a CharSequence should be enough to remove any spannable elements from the intent extra.

Change-Id: Icd238bcff3e5c1dc7ecf27f97589ac01530f53da
Fix: 355350222
Test: manual
parent 4dd6ff97

packages/SoundPicker/src/com/android/soundpicker/RingtonePickerActivity.java

+2 −2
Original line number Diff line number Diff line
@@ -255,8 +255,8 @@ public final class RingtonePickerActivity extends AlertActivity implements 
                p.mTitle = getString(com.android.internal.R.string.ringtone_picker_title);

            }

        } else {

            // Make sure intents don't inject HTML elements.

            p.mTitle = Html.escapeHtml(p.mTitle.toString());

            // Make sure intents don't inject spannable elements.

            p.mTitle = p.mTitle.toString();

        }



        setupAlert();