Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1cb1f152 authored by Andrei Stingaceanu's avatar Andrei Stingaceanu
Browse files

EditText - can not drag handles in extracted mode 

In TextView's onPreDraw method, startSelectionActionMode()
is called, but the selection has already been started so
in startSelectionActionMode() it shows the
insertionController which hides the selectionController.
Fix this by adding a check to start the action mode only
if it is not already started.

Bug: 22028858
Change-Id: I2999423155b7a63a7d879bc8ea5032e17dff459f
parent 2e561546

core/java/android/widget/TextView.java

+2 −1
Original line number Diff line number Diff line
@@ -5230,7 +5230,8 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener 
        // Phone specific code (there is no ExtractEditText on tablets).

        // ExtractEditText does not call onFocus when it is displayed, and mHasSelectionOnFocus can

        // not be set. Do the test here instead.

        if (this instanceof ExtractEditText && hasSelection() && mEditor != null) {

        if (isInExtractedMode() && hasSelection() && mEditor != null

                && mEditor.mTextActionMode == null) {

            mEditor.startSelectionActionMode();

        }