Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 15028685 authored by Yohei Yukawa's avatar Yohei Yukawa
Browse files

Remove RemoteException handlings from AutofillSuggestionsController

This is a follow up CL to our previous CL [1], which introduced

  InlineSuggestionsRequestCallbackDecorator

that wraps

  InlineSuggestionsRequestCallbackImpl

to intercept IPC calls then inject special logic.

The problem is that when forwarding IPC calls within system_server
process, the AIDL-generated method stub forces us to handle
RemoteException, which actually never happen if the target Binder
object is in the same process. To clarify this nuance, this CL
introduces a plain Java interface

  com.android.internal.inputmethod.InlineSuggestionsRequestCallback

as a mirror of IInlineSuggestionsRequestCallback.

As you can see in this CL, doing so eliminates many RemoteException.

This is a mechanical code change with no observable behavior.

 [1]: I3d81b1d56989e46f65f9b9fc6e497952486335b5
      16b2de5a

Bug: 339358344
Test: atest CtsAutoFillServiceTestCases
Test: atest CtsInputMethodTestCases
Change-Id: I25a75b47aaed29a42b153a7874e5bf26ca89df98
parent c9cb114c
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment