Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 130e1294 authored by Taeho Kim's avatar Taeho Kim
Browse files

Fixed Drag-and-Drop sample code 

Fixed some erros in 'Responding to drag events' sample code on
http://developer.android.com/guide/topics/ui/drag-drop.html



Changed View.OnDragEventListener to View.OnDragListener,
deleted brace start('{') after DragEvent.ACTION_DRAG_ENTERED which
does not have matching ends, and removed 'break' on each case in
swich statement which causes 'Unreachable code' error.
Added return statement at the 'default' case, so that onDrag() method
can return value in all case.

Change-Id: I7d2335f5c405626e3f0cff275b52818762c84634
Signed-off-by: default avatarTaeho Kim <jyte82@gmail.com>
parent a1b4d97b

docs/html/guide/topics/ui/drag-drop.jd

+47 −59
Original line number Diff line number Diff line
@@ -873,7 +873,7 @@ imageView.setOnDragListener(mDragListen); 


...



protected class myDragEventListener implements View.OnDragEventListener {

protected class myDragEventListener implements View.OnDragListener {



    // This is the method that the system calls when it dispatches a drag event to the

    // listener.
@@ -901,16 +901,13 @@ protected class myDragEventListener implements View.OnDragEventListener { 
                    // returns true to indicate that the View can accept the dragged data.

                    return(true);



                    } else {

                }



                // Returns false. During the current drag and drop operation, this View will

                // not receive events again until ACTION_DRAG_ENDED is sent.

                return(false);



                    }

                break;



            case DragEvent.ACTION_DRAG_ENTERED: {

            case DragEvent.ACTION_DRAG_ENTERED:



                // Applies a green tint to the View. Return true; the return value is ignored.
@@ -921,15 +918,11 @@ protected class myDragEventListener implements View.OnDragEventListener { 


                return(true);



                break;



            case DragEvent.ACTION_DRAG_LOCATION:



                // Ignore the event

                return(true);



                break;



            case DragEvent.ACTION_DRAG_EXITED:



                // Re-sets the color tint to blue. Returns true; the return value is ignored.
@@ -940,8 +933,6 @@ protected class myDragEventListener implements View.OnDragEventListener { 


                return(true);



                break;



            case DragEvent.ACTION_DROP:



                // Gets the item containing the dragged data
@@ -962,8 +953,6 @@ protected class myDragEventListener implements View.OnDragEventListener { 
                // Returns true. DragEvent.getResult() will return true.

                return(true);



                break;



            case DragEvent.ACTION_DRAG_ENDED:



                // Turns off any color tinting
@@ -979,19 +968,18 @@ protected class myDragEventListener implements View.OnDragEventListener { 
                } else {

                    Toast.makeText(this, "The drop didn't work.", Toast.LENGTH_LONG);



                    };

                }



                // returns true; the value is ignored.

                return(true);



                break;



            // An unknown action type was received.

            default:

                Log.e("DragDrop Example","Unknown action type received by OnDragListener.");



                break;

        };

    };

        }

        

        return(false);

    }

};

</pre>