Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0b2c9f07 authored by Graciela Wissen Putri's avatar Graciela Wissen Putri
Browse files

Clean up surface if button is hidden 

If UserAspectRatioSettingsLayout hides button, the surface was still
visible even though the view is hidden. Touches still go to the surface
until the next task info update which will release the surface as it is
no longer eligible to layout.

We should release the surface if button should be hidden.

Fix: 385049711
Flag: com.android.window.flags.release_user_aspect_ratio_wm
Test: Locally
Change-Id: Ibf9c90aebe28c17ef7bef660f8bba25b14568af5
parent 68fe97e6

core/java/android/window/flags/large_screen_experiences_app_compat.aconfig

+10 −0
Original line number Diff line number Diff line
@@ -163,3 +163,13 @@ flag { 
  bug: "372848702"

  is_exported: true

}



flag {

  name: "release_user_aspect_ratio_wm"

  namespace: "large_screen_experiences_app_compat"

  description: "Whether to release UserAspectRatioSettingsWindowManager when button is hidden"

  bug: "385049711"

  metadata {

    purpose: PURPOSE_BUGFIX

  }

}
 
 No newline at end of file

libs/WindowManager/Shell/src/com/android/wm/shell/compatui/UserAspectRatioSettingsLayout.java

+4 −0
Original line number Diff line number Diff line
@@ -32,6 +32,7 @@ import android.widget.ImageButton; 
import android.widget.LinearLayout;

import android.widget.TextView;



import com.android.window.flags.Flags;

import com.android.wm.shell.R;



/**
@@ -172,6 +173,9 @@ public class UserAspectRatioSettingsLayout extends LinearLayout { 
            @Override

            public void onAnimationEnd(Animator animation) {

                view.setVisibility(View.GONE);

                if (Flags.releaseUserAspectRatioWm()) {

                    mWindowManager.release();

                }

            }

        });

        fadeOut.start();