Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 08d389c6 authored by Chih-hung Hsieh's avatar Chih-hung Hsieh Committed by Automerger Merge Worker
Browse files

Merge "Do not add quotes around flags argument" am: af4f8b95 am: d82f6409 am: 703eb2b0 

Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1598500

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Icbde547c69af26710147c03b73437f5db5121f10
parents fd08d9ea 703eb2b0

media/jni/soundpool/Android.bp

+8 −5
Original line number Diff line number Diff line
@@ -45,26 +45,30 @@ tidy_errors = [ 
    "modernize-return-braced-init-list",

    "modernize-shrink-to-fit",

    "modernize-unary-static-assert",

    "modernize-use-auto",  // debatable - auto can obscure type

    // "modernize-use-auto",  // found in StreamManager.h, debatable - auto can obscure type

    "modernize-use-bool-literals",

    "modernize-use-default-member-init",

    "modernize-use-emplace",

    "modernize-use-equals-default",

    "modernize-use-equals-delete",

    "modernize-use-nodiscard",

    // "modernize-use-nodiscard", // found in SteamManager.h

    "modernize-use-noexcept",

    "modernize-use-nullptr",

    "modernize-use-override",

    //"modernize-use-trailing-return-type", // not necessarily more readable

    "modernize-use-transparent-functors",

    "modernize-use-uncaught-exceptions",

    "modernize-use-using",

    //"modernize-use-using", // found in SoundManager.h

    "performance-*",



    // Remove some pedantic stylistic requirements.

    "-google-readability-casting", // C++ casts not always necessary and may be verbose

    "-google-readability-todo",    // do not require TODO(info)

    "-google-build-using-namespace", // Reenable and fix later.



    "-google-explicit-constructor", // found in StreamManager.h

    "-misc-non-private-member-variables-in-classes", // found in SoundManager.h

    "-performance-unnecessary-value-param", // found in StreamManager.h

]



cc_defaults {
@@ -96,8 +100,7 @@ cc_defaults { 
    tidy_checks: tidy_errors,

    tidy_checks_as_errors: tidy_errors,

    tidy_flags: [

      "-format-style='file'",

      "--header-filter='frameworks/base/media/jni/soundpool'",

      "-format-style=file",

    ],

}