Merge "Do not add quotes around flags argument"

    "modernize-return-braced-init-list",

    "modernize-shrink-to-fit",

    "modernize-unary-static-assert",

    "modernize-use-auto",  // debatable - auto can obscure type

    // "modernize-use-auto",  // found in StreamManager.h, debatable - auto can obscure type

    "modernize-use-bool-literals",

    "modernize-use-default-member-init",

    "modernize-use-emplace",

    "modernize-use-equals-default",

    "modernize-use-equals-delete",

    "modernize-use-nodiscard",

    // "modernize-use-nodiscard", // found in SteamManager.h

    "modernize-use-noexcept",

    "modernize-use-nullptr",

    "modernize-use-override",

    //"modernize-use-trailing-return-type", // not necessarily more readable

    "modernize-use-transparent-functors",

    "modernize-use-uncaught-exceptions",

    "modernize-use-using",

    //"modernize-use-using", // found in SoundManager.h

    "performance-*",

    // Remove some pedantic stylistic requirements.

    "-google-readability-casting", // C++ casts not always necessary and may be verbose

    "-google-readability-todo",    // do not require TODO(info)

    "-google-build-using-namespace", // Reenable and fix later.

    "-google-explicit-constructor", // found in StreamManager.h

    "-misc-non-private-member-variables-in-classes", // found in SoundManager.h

    "-performance-unnecessary-value-param", // found in StreamManager.h

]

cc_defaults {

    tidy_checks: tidy_errors,

    tidy_checks_as_errors: tidy_errors,

    tidy_flags: [

      "-format-style='file'",

      "--header-filter='frameworks/base/media/jni/soundpool'",

      "-format-style=file",

    ],

}