Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06416b9e authored by Selim Cinek's avatar Selim Cinek
Browse files

Fixed a crash with min-priority notifications in a group 

Those notifications could get into a group with higher priority
because they were autobundled or if the app said so.
This could lead to invisible views on the lockscreen and a crash
when this happened in an animated fashion.
The bug was triggering old code that wasn't needed anymore that
removed the viewstate.

Change-Id: Ic86c2f03d55f2e98e352cdbfbb3ca80d8e676765
Fixes: 28611831
parent c0b14b0e

packages/SystemUI/src/com/android/systemui/statusbar/BaseStatusBar.java

+2 −3
Original line number Diff line number Diff line
@@ -2168,9 +2168,8 @@ public abstract class BaseStatusBar extends SystemUI implements 
                    == View.VISIBLE;

            boolean showOnKeyguard = shouldShowOnKeyguard(entry.notification);

            if (suppressedSummary || (isLockscreenPublicMode() && !mShowLockscreenNotifications) ||

                    (onKeyguard && (visibleNotifications >= maxNotifications

                            && !childWithVisibleSummary

                            || !showOnKeyguard))) {

                    (onKeyguard && !childWithVisibleSummary

                            && (visibleNotifications >= maxNotifications || !showOnKeyguard))) {

                entry.row.setVisibility(View.GONE);

                if (onKeyguard && showOnKeyguard && !childNotification && !suppressedSummary) {

                    mKeyguardIconOverflowContainer.getIconsView().addNotification(entry);

packages/SystemUI/src/com/android/systemui/statusbar/stack/StackStateAnimator.java

+0 −5
Original line number Diff line number Diff line
@@ -823,11 +823,6 @@ public class StackStateAnimator { 
                    // The position for this child was never generated, let's continue.

                    continue;

                }

                if (changingView.getVisibility() == View.GONE) {

                    // The view was set to gone but the state never removed

                    finalState.removeViewStateForView(changingView);

                    continue;

                }

                finalState.applyState(changingView, viewState);

                mNewAddChildren.add(changingView);