Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c0b14b0e authored by Selim Cinek's avatar Selim Cinek
Browse files

Fixed a concurrent modification crash 

Because notifications could become isolated when
the group is suppressed it could lead to concurrent
modifications while looping.

Change-Id: Ifd4fe0cc24110455de0d3edf2da0be0773eb8c67
Fixes: 28652038
parent 52941c56

packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationGroupManager.java

+7 −1
Original line number Diff line number Diff line
@@ -26,6 +26,7 @@ import com.android.systemui.statusbar.policy.HeadsUpManager; 


import java.io.FileDescriptor;

import java.io.PrintWriter;

import java.util.ArrayList;

import java.util.HashMap;

import java.util.HashSet;

import java.util.Iterator;
@@ -239,7 +240,12 @@ public class NotificationGroupManager implements HeadsUpManager.OnHeadsUpChanged 
    }



    public void collapseAllGroups() {

        for (NotificationGroup group : mGroupMap.values()) {

        // Because notifications can become isolated when the group becomes suppressed it can

        // lead to concurrent modifications while looping. We need to make a copy.

        ArrayList<NotificationGroup> groupCopy = new ArrayList<>(mGroupMap.values());

        int size = groupCopy.size();

        for (int i = 0; i < size; i++) {

            NotificationGroup group =  groupCopy.get(i);

            if (group.expanded) {

                setGroupExpanded(group, false);

            }