Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 04931014 authored by Kevin Lubick's avatar Kevin Lubick
Browse files

[base] Replace SkFontMgr::RefDefault() with FreeTypeFontMgr 

Android Renderengine doesn't draw any text, but hwui needs
to turn bytes into SkTypefaces and it currently uses Skia's
"Empty Custom" SkFontMgr, which is really just a wrapper around
FreeType. This makes that connection explicit instead of relying
on SkFontMgr::RefDefault(), which is going away soon.

Change-Id: Ida96538c76e069ec86e8dc078ef329cfaeac5d78
Bug: b/305780908
parent 4e884178

libs/hwui/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -553,6 +553,7 @@ cc_defaults { 
        "utils/Blur.cpp",

        "utils/Color.cpp",

        "utils/LinearAllocator.cpp",

        "utils/TypefaceUtils.cpp",

        "utils/VectorDrawableUtils.cpp",

        "AnimationContext.cpp",

        "Animator.cpp",

libs/hwui/hwui/MinikinSkia.cpp

+2 −1
Original line number Diff line number Diff line
@@ -30,6 +30,7 @@ 
#include <minikin/MinikinExtent.h>

#include <minikin/MinikinPaint.h>

#include <minikin/MinikinRect.h>

#include <utils/TypefaceUtils.h>



namespace android {
@@ -142,7 +143,7 @@ std::shared_ptr<minikin::MinikinFont> MinikinFontSkia::createFontWithVariation( 
        skVariation[i].value = SkFloatToScalar(variations[i].value);

    }

    args.setVariationDesignPosition({skVariation.data(), static_cast<int>(skVariation.size())});

    sk_sp<SkFontMgr> fm(SkFontMgr::RefDefault());

    sk_sp<SkFontMgr> fm = android::FreeTypeFontMgr();

    sk_sp<SkTypeface> face(fm->makeFromStream(std::move(stream), args));



    return std::make_shared<MinikinFontSkia>(std::move(face), mSourceId, mFontData, mFontSize,

libs/hwui/jni/FontFamily.cpp

+2 −1
Original line number Diff line number Diff line
@@ -31,6 +31,7 @@ 
#include <minikin/FontFamily.h>

#include <minikin/LocaleList.h>

#include <ui/FatVector.h>

#include <utils/TypefaceUtils.h>



#include <memory>
@@ -125,7 +126,7 @@ static bool addSkTypeface(NativeFamilyBuilder* builder, sk_sp<SkData>&& data, in 
    args.setCollectionIndex(ttcIndex);

    args.setVariationDesignPosition({skVariation.data(), static_cast<int>(skVariation.size())});



    sk_sp<SkFontMgr> fm(SkFontMgr::RefDefault());

    sk_sp<SkFontMgr> fm = android::FreeTypeFontMgr();

    sk_sp<SkTypeface> face(fm->makeFromStream(std::move(fontData), args));

    if (face == NULL) {

        ALOGE("addFont failed to create font, invalid request");

libs/hwui/jni/fonts/Font.cpp

+2 −1
Original line number Diff line number Diff line
@@ -37,6 +37,7 @@ 
#include <minikin/LocaleList.h>

#include <minikin/SystemFonts.h>

#include <ui/FatVector.h>

#include <utils/TypefaceUtils.h>



#include <memory>
@@ -459,7 +460,7 @@ std::shared_ptr<minikin::MinikinFont> createMinikinFontSkia( 
    args.setCollectionIndex(ttcIndex);

    args.setVariationDesignPosition({skVariation.data(), static_cast<int>(skVariation.size())});



    sk_sp<SkFontMgr> fm(SkFontMgr::RefDefault());

    sk_sp<SkFontMgr> fm = android::FreeTypeFontMgr();

    sk_sp<SkTypeface> face(fm->makeFromStream(std::move(fontData), args));

    if (face == nullptr) {

        return nullptr;

libs/hwui/tests/unit/TypefaceTests.cpp

+2 −1
Original line number Diff line number Diff line
@@ -29,6 +29,7 @@ 


#include "hwui/MinikinSkia.h"

#include "hwui/Typeface.h"

#include "utils/TypefaceUtils.h"



using namespace android;
@@ -56,7 +57,7 @@ std::shared_ptr<minikin::FontFamily> buildFamily(const char* fileName) { 
    sk_sp<SkData> skData =

            SkData::MakeWithProc(data, st.st_size, unmap, reinterpret_cast<void*>(st.st_size));

    std::unique_ptr<SkStreamAsset> fontData(new SkMemoryStream(skData));

    sk_sp<SkFontMgr> fm(SkFontMgr::RefDefault());

    sk_sp<SkFontMgr> fm = android::FreeTypeFontMgr();

    sk_sp<SkTypeface> typeface(fm->makeFromStream(std::move(fontData)));

    LOG_ALWAYS_FATAL_IF(typeface == nullptr, "Failed to make typeface from %s", fileName);

    std::shared_ptr<minikin::MinikinFont> font =