Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 03266b5d authored by Linus Tufvesson's avatar Linus Tufvesson Committed by Shai Barack
Browse files

Add oneway_finalizer_close_fixed flag 

This flag will replace oneway_finalizer_close, only difference is that
this new flag is declared with `is_fixed_read_only`.

Some apps trigger the code path before configprovider has been made
available to the client process causing a crash.

Bug: 368221351
Bug: 376942274
Test: atest FrameworksCoreTests:android.database
Change-Id: If09fa42d09e1f327632ae81b10aea5cd3929b5cf
parent 238801c3

core/java/android/database/BulkCursorNative.java

+1 −1
Original line number Diff line number Diff line
@@ -215,7 +215,7 @@ final class BulkCursorProxy implements IBulkCursor { 
            // If close() is being called from the finalizer thread, do not wait for a reply from

            // the remote side.

            final boolean fromFinalizer =

                    android.database.sqlite.Flags.onewayFinalizerClose()

                    android.database.sqlite.Flags.onewayFinalizerCloseFixed()

                    && "FinalizerDaemon".equals(Thread.currentThread().getName());

            mRemote.transact(CLOSE_TRANSACTION, data, reply,

                    fromFinalizer ? IBinder.FLAG_ONEWAY: 0);

core/java/android/database/sqlite/flags.aconfig

+8 −0
Original line number Diff line number Diff line
@@ -8,6 +8,14 @@ flag { 
     bug: "368221351"

}



flag {

     name: "oneway_finalizer_close_fixed"

     namespace: "system_performance"

     is_fixed_read_only: true

     description: "Make BuildCursorNative.close oneway if in the the finalizer"

     bug: "368221351"

}



flag {

     name: "sqlite_apis_35"

     is_exported: true