Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 0234597b authored by Steve Elliott's avatar Steve Elliott
Browse files

Prevent desync of NICViewBinder + NotifCollection

There is a potential race condition where the NotifCollection removes a
notification before the NICViewBinder attempts to bind its icon. In this
state, the NICViewBinder believes that the icon should be present, but
in reality the icon is about to be removed by the next pipeline run.

The fix tracks icons that "fail" to bind in this way. The expectation is
that this tracking is ephemeral, and will be cleared by the next update
from the ViewModel, after the pipeline has run again. This tracking is
dumped in a bug report to identify situations where there are repeated
failures to bind, indicating a more significant logic issue.

Flag: ACONFIG com.android.systemui.notifications_icon_container_refactor DEVELOPMENT
Fixes: 309555139
Bug: 278765923
Test: manual - repeatedly unplug and replug the phone into USB
      debugging, observe no crash.
Change-Id: I49e5cf068bf5156a2d6df6a6870d062a773d9ff5
parent 1b433c6a
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment