Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0166c353 authored by Brad Fitzpatrick's avatar Brad Fitzpatrick
Browse files

Explicitly mention again that startCommand() runs on the main thread. 

This is already mentioned at the top of Service.java's javadoc, but
I'm seeing people get confused (myself included the other day) after
getting used to incoming service stub binder calls being on their own
threads and forgetting that startCommand() didn't work that way.

Change-Id: Ib79f48d9368ac0ba2d37b7e4dc98d53804bcd59e
parent 7bcad8a3

core/java/android/app/Service.java

+9 −1
Original line number Diff line number Diff line
@@ -401,6 +401,14 @@ public abstract class Service extends ContextWrapper implements ComponentCallbac 
     * {@sample development/samples/ApiDemos/src/com/example/android/apis/app/ForegroundService.java

     *   start_compatibility}

     *

     * <p class="caution">Note that the system calls this on your

     * service's main thread.  A service's main thread is the same

     * thread where UI operations place for Activities running in the

     * same process.  You should always avoid stalling the main

     * thread's event loop.  When doing long-running operations,

     * network calls, or heavy disk I/O, you should kick off a new

     * thread, or use {@link android.os.AsyncTask}.</p>

     *

     * @param intent The Intent supplied to {@link android.content.Context#startService}, 

     * as given.  This may be null if the service is being restarted after

     * its process has gone away, and it had previously returned anything