Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f29870be authored by George Burgess IV's avatar George Burgess IV Committed by George Burgess
Browse files

TargetAudioEncTest: use vector instead of malloc 

The static analyzer noted that we'll fail to `free` this `malloc()` if any
ASSERT between it and the `free()` fails. Just use a `vector<char>`
instead, since that handles freeing for us.

Bug: 206470603
Test: TreeHugger
Change-Id: I2c7edab803420beb9f4d72c83f6a770fb053413e
parent d5fdf9c3

media/codec2/hidl/1.0/vts/functional/audio/VtsHalMediaC2V1_0TargetAudioEncTest.cpp

+3 −5
Original line number Diff line number Diff line
@@ -372,9 +372,8 @@ void encodeNFrames(const std::shared_ptr<android::Codec2Client::Component>& comp 
            ULock l(queueLock);

            flushedIndices.emplace_back(frameID);

        }

        char* data = (char*)malloc(bytesCount);

        ASSERT_NE(data, nullptr);

        eleStream.read(data, bytesCount);

        std::vector<char> eleData(bytesCount);

        eleStream.read(eleData.data(), bytesCount);

        // if we have reached at the end of input stream, signal eos

        if (eleStream.gcount() < bytesCount) {

            bytesCount = eleStream.gcount();
@@ -396,12 +395,11 @@ void encodeNFrames(const std::shared_ptr<android::Codec2Client::Component>& comp 
        ASSERT_EQ(0u, view.offset());

        ASSERT_EQ((size_t)bytesCount, view.size());



        memcpy(view.base(), data, bytesCount);

        memcpy(view.base(), eleData.data(), bytesCount);

        work->input.buffers.clear();

        work->input.buffers.emplace_back(new LinearBuffer(block));

        work->worklets.clear();

        work->worklets.emplace_back(new C2Worklet);

        free(data);



        std::list<std::unique_ptr<C2Work>> items;

        items.push_back(std::move(work));