Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f18ea7c1 authored by Greg Kaiser's avatar Greg Kaiser
Browse files

Initialize field in constructor 

Rather than risk a poorly written future test failing to call
setOverrideCameraDisabled() prior to isCameraDisabled() being
called, we just make sure sure this field has a consistently
set value.  This will help protect against a "flaky" future
test that would have been using uninitialized memory.

Test: TreeHugger
Change-Id: Ie6d9bb7df25786d2c5f6064d897949ffccbe6e72
parent b46a7e65

services/camera/libcameraservice/tests/CameraPermissionsTest.cpp

+1 −1
Original line number Diff line number Diff line
@@ -120,7 +120,7 @@ class CameraServiceProxyOverride : public ::android::hardware::BnCameraServicePr 
public:

    CameraServiceProxyOverride() :

            mCameraServiceProxy(CameraServiceProxyWrapper::getDefaultCameraServiceProxy()),

            mCameraDisabled(false)

            mCameraDisabled(false), mOverrideCameraDisabled(false)

    { }



    virtual binder::Status getRotateAndCropOverride(const String16& packageName, int lensFacing,