Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f0658f4e authored by Ytai Ben-Tsvi's avatar Ytai Ben-Tsvi
Browse files

Remove manual parceling from Interpolator and VolumeShaper 

Created stable parcelables to hold all the data that gets parceled.
Replaced manual parceling with a two-step approach, where we first
write into the auto-generated parcelable, then parcel it.

Test: Ran audio-related CTS tests
Bug: 160253486
Change-Id: I5a4d51fb1244ed49bcd70e446aaa26e2aa8ed7b1
parent a3815207

Android.bp

0 → 100644
+27 −0
Original line number Diff line number Diff line 
aidl_interface {

    name: "av-types-aidl",

    unstable: true,

    host_supported: true,

    vendor_available: true,

    double_loadable: true,

    local_include_dir: "aidl",

    srcs: [

        "aidl/android/media/InterpolatorConfig.aidl",

        "aidl/android/media/InterpolatorType.aidl",

        "aidl/android/media/VolumeShaperConfiguration.aidl",

        "aidl/android/media/VolumeShaperConfigurationOptionFlag.aidl",

        "aidl/android/media/VolumeShaperConfigurationType.aidl",

        "aidl/android/media/VolumeShaperOperation.aidl",

        "aidl/android/media/VolumeShaperOperationFlag.aidl",

        "aidl/android/media/VolumeShaperState.aidl",

    ],

    backend: {

        cpp: {

            min_sdk_version: "29",

            apex_available: [

                "//apex_available:platform",

                "com.android.media",

            ],

        },

    },

}

aidl/android/media/InterpolatorConfig.aidl

0 → 100644
+31 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2020 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *      http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License.

 */



package android.media;



import android.media.InterpolatorType;



/**

 * {@hide}

 */

parcelable InterpolatorConfig {

    InterpolatorType type;

    /** For cubic interpolation, the boundary conditions in slope. */

    float firstSlope;

    float lastSlope;

    /** A flattened list of <x, y> pairs, monotonically increasing in x. */

    float[] xy;

}

aidl/android/media/InterpolatorType.aidl

0 → 100644
+34 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2020 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *      http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License.

 */

package android.media;



/**

 * Polynomial spline interpolators.

 *

 * {@hide}

 */

@Backing(type="int")

enum InterpolatorType {

    /** Not continuous. */

    STEP,

    /** C0. */

    LINEAR,

    /** C1. */

    CUBIC,

    /** C1 (to provide locally monotonic curves). */

    CUBIC_MONOTONIC,

    // CUBIC_C2, // TODO - requires global computation / cache

}

aidl/android/media/VolumeShaperConfiguration.aidl

0 → 100644
+33 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2020 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *      http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License.

 */



package android.media;



import android.media.InterpolatorConfig;

import android.media.VolumeShaperConfigurationOptionFlag;

import android.media.VolumeShaperConfigurationType;



/**

 * {@hide}

 */

parcelable VolumeShaperConfiguration {

    VolumeShaperConfigurationType type;

    int id;

    /** Bitmask, indexed by VolumeShaperConfigurationOptionFlag. */

    int optionFlags;

    double durationMs;

    InterpolatorConfig interpolatorConfig;

}

media/libaudioclient/aidl/android/media/VolumeShaper/Operation.aidl→aidl/android/media/VolumeShaperConfigurationOptionFlag.aidl

+7 −4
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2017 The Android Open Source Project

 * Copyright (C) 2020 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.
@@ -13,7 +13,10 @@ 
 * See the License for the specific language governing permissions and

 * limitations under the License.

 */

package android.media;



package android.media.VolumeShaper;



parcelable Operation cpp_header "media/VolumeShaper.h";
 
@Backing(type="int")

enum VolumeShaperConfigurationOptionFlag {

    VOLUME_IN_DBFS,

    CLOCK_TIME,

}