Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit ca5beef3 authored by wjiang's avatar wjiang Committed by Linux Build Service Account
Browse files

libeffect: Fix enabled effect count calculation error

When switching from tunnel to arm effects, effect chain will be moved
from offload thread to mixer thread. During this procedure effect instance
is not destroyed, instead it's preserved and mounted onto new chain.

The migrant sequence is 1) disable instance -> 2) move to new effect
chain -> 3) enable instance again. However, the accumulated effect
enabled count is not decreased when effect instance is disabled.

As a result, LvmBundle_process() is only called once when Effect_process()
called twice, which causes input buffer get processed alternately and
glitch sound appears.

CRs-Fixed: 1016867

Conflicts:
	media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
	media/libeffects/lvm/wrapper/Bundle/EffectBundle.h

Change-Id: Idd3b8753a73694cc36617ed55b40fda93155abed
parent 2c103d6f
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment