Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6ba2fd0 authored by Eric Laurent's avatar Eric Laurent Committed by Android (Google) Code Review
Browse files

audioflinger: improve record start and thread exit 

Use broadcast() instead of signal() on the
thread wake up condition when starting record or requesting thread
exit to make sure that if another thread is waiting for the same
condition (e.g binder thread calling setParameters()) the mixer
thread will be woken up.

Bug 7184317.

Change-Id: I3154a4509ca7af6ffae5236e522b0fab8e75ed06
parent 2a865ad8

services/audioflinger/AudioFlinger.cpp

+2 −2
Original line number Diff line number Diff line
@@ -1175,7 +1175,7 @@ void AudioFlinger::ThreadBase::exit() 
        //  }

        AutoMutex lock(mLock);

        requestExit();

        mWaitWorkCV.signal();

        mWaitWorkCV.broadcast();

    }

    // When Thread::requestExitAndWait is made virtual and this method is renamed to

    // "virtual status_t requestExitAndWait()", replace by "return Thread::requestExitAndWait();"
@@ -6323,7 +6323,7 @@ status_t AudioFlinger::RecordThread::start(RecordThread::RecordTrack* recordTrac 
        mActiveTrack->mState = TrackBase::RESUMING;

        // signal thread to start

        ALOGV("Signal record thread");

        mWaitWorkCV.signal();

        mWaitWorkCV.broadcast();

        // do not wait for mStartStopCond if exiting

        if (exitPending()) {

            mActiveTrack.clear();