Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b2fa420f authored by Aaron Okano's avatar Aaron Okano
Browse files

Change IAfEffectChain::sendMetadata_l to pure virtual 

I encountered a "missing key function" error [1] for IAfEffectChain while experimenting with some compiler options, and the cause was that there is no definition for IAfEffectChain::sendMetadata_l. Because it does not appear that there is any intention of providing a default implementation in the base class, the appropriate fix for the error should be to make the function pure virtual instead.

[1]: https://lld.llvm.org/missingkeyfunction
Flag: EXEMPT refactor
Change-Id: I5ee49b88c07945e9b4fb58a0c81e5816a0902b9c
parent 4a3d39de

services/audioflinger/IAfEffect.h

+2 −1
Original line number Diff line number Diff line
@@ -345,7 +345,8 @@ public: 


    // sendMetadata_l() must be called with thread->mLock held

    virtual void sendMetadata_l(const std::vector<playback_track_metadata_v7_t>& allMetadata,

        const std::optional<const std::vector<playback_track_metadata_v7_t>> spatializedMetadata);

                                const std::optional<const std::vector<playback_track_metadata_v7_t>>

                                        spatializedMetadata) = 0;



    virtual void dump(int fd, const Vector<String16>& args) const = 0;

};