Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab46367f authored by Brijesh Patel's avatar Brijesh Patel Committed by Wonsik Kim
Browse files

codec2: Avoid sending input done event for incomplete work 

- In cases where single input buffer can produce multiple
  outputs, any work done event triggers input done event in
  surface mode and does not wait for input buffer done event
  from component. This can make producer to overwrite graphic
  buffer that is still being processesed by codec leading to
  corruption in output.
- Added check to not send input done event to surface if output
  buffer flag is set to FLAG_INCOMPLETE

Bug: 174725323
Test: cts/media/device-small
Change-Id: I1164bf5c61e3fce346e51a57620ee68914a517ec
parent de7ebba5

media/codec2/sfplugin/CCodec.cpp

+6 −1
Original line number Diff line number Diff line
@@ -2264,8 +2264,13 @@ void CCodec::onMessageReceived(const sp<AMessage> &msg) { 
                    }

                }

                if (config->mInputSurface) {

                    if (work->worklets.empty()

                           || !work->worklets.back()

                           || (work->worklets.back()->output.flags

                                  & C2FrameData::FLAG_INCOMPLETE) == 0) {

                        config->mInputSurface->onInputBufferDone(work->input.ordinal.frameIndex);

                    }

                }

                if (initDataWatcher.hasChanged()) {

                    initData = initDataWatcher.update();

                    AmendOutputFormatWithCodecSpecificData(