Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a8f90c19 authored by George Burgess IV's avatar George Burgess IV
Browse files

av: remove a redundant NULL check 

The unconditional `readInputParameters_l` call below this condition
immediately and unconditionally dereferences `mInput`. Either
`readInputParameters_l` needs to handle a null `mInput` reasonably, or
`mInput` can never be null. This CL assumes the latter.

Bug: None
Test: TreeHugger
Change-Id: I46f89f918257f9d4aa762a03c3d03e030a17b4a9
parent 3ec7c256

services/audioflinger/Threads.cpp

+1 −1
Original line number Original line Diff line number Diff line
@@ -6725,7 +6725,7 @@ AudioFlinger::RecordThread::RecordThread(const sp<AudioFlinger>& audioFlinger, 
    snprintf(mThreadName, kThreadNameLength, "AudioIn_%X", id);

    snprintf(mThreadName, kThreadNameLength, "AudioIn_%X", id);

    mNBLogWriter = audioFlinger->newWriter_l(kLogSize, mThreadName);

    mNBLogWriter = audioFlinger->newWriter_l(kLogSize, mThreadName);





    if (mInput != nullptr && mInput->audioHwDev != nullptr) {

    if (mInput->audioHwDev != nullptr) {

        mIsMsdDevice = strcmp(

        mIsMsdDevice = strcmp(

                mInput->audioHwDev->moduleName(), AUDIO_HARDWARE_MODULE_ID_MSD) == 0;

                mInput->audioHwDev->moduleName(), AUDIO_HARDWARE_MODULE_ID_MSD) == 0;

    }

    }