Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c31ae07 authored by James Dong's avatar James Dong
Browse files

Use AACEncoder instead of OMX-based AAC software encoder to workaround issues... 

Use AACEncoder instead of OMX-based AAC software encoder to workaround issues in the video editor engine

o related-to-bug: 5947347

Change-Id: I8eae8166e87e5809e2f3699f760f3a3e57895b4f
parent a789d6c0

libvideoeditor/vss/stagefrightshells/src/VideoEditorAudioEncoder.cpp

+9 −2
Original line number Diff line number Diff line
@@ -443,9 +443,16 @@ M4OSA_ERR VideoEditorAudioEncoder_open(M4OSA_Context pContext, 
#ifdef VIDEOEDITOR_FORCECODEC

    codecFlags |= OMXCodec::VIDEOEDITOR_FORCECODEC;

#endif /* VIDEOEDITOR_FORCECODEC */

    // FIXME:

    // We are moving away to use software AACEncoder and instead use OMX-based

    // software AAC audio encoder. We want to use AACEncoder for now. After we

    // fix the interface issue with the OMX-based AAC audio encoder, we should

    // then set the component name back to NULL to allow the system to pick up

    // the right AAC audio encoder.

    pEncoderContext->mEncoder = OMXCodec::Create(

            pEncoderContext->mClient.interface(), encoderMetadata, true,

        pEncoderContext->mEncoderSource, NULL, codecFlags);

            pEncoderContext->mEncoderSource, "AACEncoder" /* component name */,

            codecFlags);

    VIDEOEDITOR_CHECK(NULL != pEncoderContext->mEncoder.get(), M4ERR_STATE);



    // Start the graph