Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 84d4018d authored by Harish Mahendrakar's avatar Harish Mahendrakar Committed by hkuang
Browse files

libmediatranscoder: Android.bp updates 

- Build libmediatranscoder as both shared and static libraries
- Use libmediatranscoder static library in unit tests
- Disable address sanitizer in tests
- Do not use address sanitizer enabled library in tests

Instead of enabling address sanitizer in Android.bp, better approach
is to test on devices flashed with hwasan images where all modules
are built with hwaddress sanitizer.

Bug: 173627260
Test: atest MediaTrackTranscoderTests

Change-Id: Id06ce520012485579c2be60348a2b38637fa7327
parent 8c92258c

media/libmediatranscoding/transcoder/Android.bp

+1 −9
Original line number Diff line number Diff line
@@ -60,16 +60,8 @@ cc_defaults { 
    },

}



cc_library_shared {

cc_library {

    name: "libmediatranscoder",

    defaults: ["mediatranscoder_defaults"],

}

cc_library_shared {

    name: "libmediatranscoder_asan",

    defaults: ["mediatranscoder_defaults"],



    sanitize: {

        address: true,

    },

}

media/libmediatranscoding/transcoder/tests/Android.bp

+4 −2
Original line number Diff line number Diff line
@@ -7,11 +7,14 @@ cc_defaults { 
        "libmedia_headers",

    ],



    static_libs: [

        "libmediatranscoder",

    ],

    shared_libs: [

        "libbase",

        "libcutils",

        "libmediandk",

        "libmediatranscoder_asan",

        "libnativewindow",

        "libutils",

    ],
@@ -26,7 +29,6 @@ cc_defaults { 
            "signed-integer-overflow",

        ],

        cfi: true,

        address: true,

    },



    data: [":test_assets"],