Effects: Check get parameter command size am: 3d34cc76e3 am: 59920bf785 (79a088a0) · Commits · e / os / android_frameworks_av

services/audioflinger/Effects.cpp

+7 −0

Original line number	Original line	Diff line number	Diff line
	@@ -563,6 +563,13 @@ status_t AudioFlinger::EffectModule::command(uint32_t cmdCode,
	android_errorWriteLog(0x534e4554, "29251553");		android_errorWriteLog(0x534e4554, "29251553");
	return -EINVAL;		return -EINVAL;
	}		}
			if (cmdCode == EFFECT_CMD_GET_PARAM &&
			(sizeof(effect_param_t) > cmdSize \|\|
			((effect_param_t *)pCmdData)->psize > cmdSize
			- sizeof(effect_param_t))) {
			android_errorWriteLog(0x534e4554, "32438594");
			return -EINVAL;
			}
	if ((cmdCode == EFFECT_CMD_SET_PARAM		if ((cmdCode == EFFECT_CMD_SET_PARAM
	\|\| cmdCode == EFFECT_CMD_SET_PARAM_DEFERRED) && // DEFERRED not generally used		\|\| cmdCode == EFFECT_CMD_SET_PARAM_DEFERRED) && // DEFERRED not generally used
	(sizeof(effect_param_t) > cmdSize		(sizeof(effect_param_t) > cmdSize