Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3d34cc76 authored by Andy Hung's avatar Andy Hung
Browse files

Effects: Check get parameter command size 

Test: Custom test.
Bug: 32438594
Bug: 32624850
Bug: 32635664
Change-Id: I9b1315e2c02f11bea395bfdcf5c1ccddccbad8a6
parent 2c28e5b1

services/audioflinger/Effects.cpp

+7 −0
Original line number Diff line number Diff line
@@ -539,6 +539,13 @@ status_t AudioFlinger::EffectModule::command(uint32_t cmdCode, 
        android_errorWriteLog(0x534e4554, "29251553");

        return -EINVAL;

    }

    if (cmdCode == EFFECT_CMD_GET_PARAM &&

            (sizeof(effect_param_t) > cmdSize ||

                    ((effect_param_t *)pCmdData)->psize > cmdSize

                                                          - sizeof(effect_param_t))) {

        android_errorWriteLog(0x534e4554, "32438594");

        return -EINVAL;

    }

    if ((cmdCode == EFFECT_CMD_SET_PARAM

            || cmdCode == EFFECT_CMD_SET_PARAM_DEFERRED) &&  // DEFERRED not generally used

        (sizeof(effect_param_t) > cmdSize