Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 63325523 authored by Sharad Sangle's avatar Sharad Sangle Committed by Gerrit - the friendly Code Review server
Browse files

audioflinger: don't call flush/resume if track is removed 

 While preparing tracks if there is no active track, flinger
 is not calling HAL pause but calling flush and resume if
 flush is pending or HAL resume is pending. This result in
 a flush to sent to HAL/below layer without pause, which
 results in unexpected behavior such as pops.

 Make sure if pause is not issued then flush/resume is also
 not issued

 CRs-Fixed: 1052627

Change-Id: I5875e8715ab92777e063a3515ab662a585a28dbb
parent c32383c0

services/audioflinger/Threads.cpp

+3 −1
Original line number Diff line number Diff line
@@ -4863,11 +4863,13 @@ AudioFlinger::PlaybackThread::mixer_state AudioFlinger::DirectOutputThread::prep 
    // If a flush is pending and a track is active but the HW is not paused, force a HW pause

    // before flush and then resume HW. This can happen in case of pause/flush/resume

    // if resume is received before pause is executed.

    bool paused = false;

    if (mHwSupportsPause && !mStandby &&

            (doHwPause || (mFlushPending && !mHwPaused && (count != 0)))) {

        mOutput->stream->pause(mOutput->stream);

        paused = true;

    }

    if (mFlushPending) {

    if (mFlushPending && paused) {

        flushHw_l();

    }

    if (mHwSupportsPause && !mStandby && doHwResume) {