Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60392db8 authored by Yi Kong's avatar Yi Kong
Browse files

Suppress fortify-source warning 

Found by clang-r510928:

AidlConversionCppNdk.cpp:1083:13: error: 'snprintf' will always be truncated; specified size is 32, but format string expands to at least 40 [-Werror,-Wfortify-source]
 1083 |             snprintf(addressBuffer, AUDIO_DEVICE_MAX_ADDRESS_LEN,
      |             ^

Test: presubmit
Change-Id: Iad914e5f5ca642e05fadb442a258ed3828388898
parent 8b949276

media/audioaidlconversion/AidlConversionCppNdk.cpp

+4 −0
Original line number Diff line number Diff line
@@ -1080,9 +1080,13 @@ AudioDeviceAddress::Tag suggestDeviceAddressTag(const AudioDeviceDescription& de 
        case Tag::ipv6: {

            const std::vector<int32_t>& ipv6 = aidl.address.get<AudioDeviceAddress::ipv6>();

            if (ipv6.size() != 8) return BAD_VALUE;

// FIXME: Code warning found by clang-r510928

#pragma clang diagnostic push

#pragma clang diagnostic ignored "-Wfortify-source"

            snprintf(addressBuffer, AUDIO_DEVICE_MAX_ADDRESS_LEN,

                    "%04X:%04X:%04X:%04X:%04X:%04X:%04X:%04X",

                    ipv6[0], ipv6[1], ipv6[2], ipv6[3], ipv6[4], ipv6[5], ipv6[6], ipv6[7]);

#pragma clang diagnostic pop

        } break;

        case Tag::alsa: {

            const std::vector<int32_t>& alsa = aidl.address.get<AudioDeviceAddress::alsa>();