Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c91f90c authored by Eric Laurent's avatar Eric Laurent
Browse files

audio policy: fix DeviceVector::getDevicesFromType() 

Fix device type comparison in DeviceVector::getDevicesFromType():
AUDIO_DEVICE_BIT_IN bit must be excluded from type comparison
and used as an orthogonal match criterium.

Change-Id: Ie7378723f5a3d613b1b045ccdda69650a9d655fc
parent 84b784dd

services/audiopolicy/managerdefault/Devices.cpp

+6 −2
Original line number Diff line number Diff line
@@ -180,10 +180,14 @@ sp<DeviceDescriptor> DeviceVector::getDeviceFromId(audio_port_handle_t id) const 
DeviceVector DeviceVector::getDevicesFromType(audio_devices_t type) const

{

    DeviceVector devices;

    bool isOutput = audio_is_output_devices(type);

    type &= ~AUDIO_DEVICE_BIT_IN;

    for (size_t i = 0; (i < size()) && (type != AUDIO_DEVICE_NONE); i++) {

        if (itemAt(i)->mDeviceType & type & ~AUDIO_DEVICE_BIT_IN) {

        bool curIsOutput = audio_is_output_devices(itemAt(i)->mDeviceType);

        audio_devices_t curType = itemAt(i)->mDeviceType & ~AUDIO_DEVICE_BIT_IN;

        if ((isOutput == curIsOutput) && ((type & curType) != 0)) {

            devices.add(itemAt(i));

            type &= ~itemAt(i)->mDeviceType;

            type &= ~curType;

            ALOGV("DeviceVector::getDevicesFromType() for type %x found %p",

                  itemAt(i)->mDeviceType, itemAt(i).get());

        }