Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b94fa82 authored by Wonsik Kim's avatar Wonsik Kim
Browse files

omx: prevent input port enable/disable for software codecs 

Bug: 29421804
Change-Id: Iba1011e9af942a6dff7f659af769a51e3f5ba66f
parent bf835e45

media/libstagefright/omx/SimpleSoftOMXComponent.cpp

+7 −0
Original line number Diff line number Diff line
@@ -469,6 +469,13 @@ void SimpleSoftOMXComponent::onPortEnable(OMX_U32 portIndex, bool enable) { 
    CHECK_EQ((int)port->mTransition, (int)PortInfo::NONE);

    CHECK(port->mDef.bEnabled == !enable);



    if (port->mDef.eDir != OMX_DirOutput) {

        ALOGE("Port enable/disable allowed only on output ports.");

        notify(OMX_EventError, OMX_ErrorUndefined, 0, NULL);

        android_errorWriteLog(0x534e4554, "29421804");

        return;

    }



    if (!enable) {

        port->mDef.bEnabled = OMX_FALSE;

        port->mTransition = PortInfo::DISABLING;