Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 29fb0f2a authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "Avoid creating sp<> from a pointer"

parents 42afcffc ae858757
Loading
Loading
Loading
Loading
+1 −1
Original line number Original line Diff line number Diff line
@@ -648,7 +648,7 @@ private:
    {
    {
    public:
    public:


        EffectClient(AudioEffect *effect) : mEffect(effect){}
        explicit EffectClient(const sp<AudioEffect>& effect) : mEffect(effect){}


        // IEffectClient
        // IEffectClient
        binder::Status controlStatusChanged(bool controlGranted) override {
        binder::Status controlStatusChanged(bool controlGranted) override {
+1 −1
Original line number Original line Diff line number Diff line
@@ -53,7 +53,7 @@ public:


    // AudioPortConfig
    // AudioPortConfig
    virtual sp<AudioPort> getAudioPort() const {
    virtual sp<AudioPort> getAudioPort() const {
        return static_cast<AudioPort*>(const_cast<DeviceDescriptorBase*>(this));
        return sp<AudioPort>::fromExisting(const_cast<DeviceDescriptorBase*>(this));
    }
    }
    virtual void toAudioPortConfig(struct audio_port_config *dstConfig,
    virtual void toAudioPortConfig(struct audio_port_config *dstConfig,
            const struct audio_port_config *srcConfig = NULL) const;
            const struct audio_port_config *srcConfig = NULL) const;