Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ae858757 authored by Mikhail Naganov's avatar Mikhail Naganov
Browse files

Avoid creating sp<> from a pointer 

The recommended practice is to use sp<>::make,
sp<>::fromExisting, or making copies from other sp<>.
This is to avoid various edge cases with RefBase.

Bug: 243364224
Test: m
Change-Id: Ie9df5ed82b03ac8686b08adaaeda267fa54a6779
parent 6d077bf3

media/libaudioclient/include/media/AudioEffect.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -648,7 +648,7 @@ private: 
    {

    {

    public:

    public:





        EffectClient(AudioEffect *effect) : mEffect(effect){}

        explicit EffectClient(const sp<AudioEffect>& effect) : mEffect(effect){}





        // IEffectClient

        // IEffectClient

        binder::Status controlStatusChanged(bool controlGranted) override {

        binder::Status controlStatusChanged(bool controlGranted) override {

media/libaudiofoundation/include/media/DeviceDescriptorBase.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -53,7 +53,7 @@ public: 




    // AudioPortConfig

    // AudioPortConfig

    virtual sp<AudioPort> getAudioPort() const {

    virtual sp<AudioPort> getAudioPort() const {

        return static_cast<AudioPort*>(const_cast<DeviceDescriptorBase*>(this));

        return sp<AudioPort>::fromExisting(const_cast<DeviceDescriptorBase*>(this));

    }

    }

    virtual void toAudioPortConfig(struct audio_port_config *dstConfig,

    virtual void toAudioPortConfig(struct audio_port_config *dstConfig,

            const struct audio_port_config *srcConfig = NULL) const;

            const struct audio_port_config *srcConfig = NULL) const;