Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2839b850 authored by Shunkai Yao's avatar Shunkai Yao
Browse files

Add backward compatibility in effect hal default implementation 

Also fix a build warnning

Bug: 322780092
Test: latest libAudioHal with V1 effect HAL
Test: atest VtsHalAudioEffectTargetTest

Change-Id: I38e0302ca162bb3bada2bdd21d948026551a4e00
parent ada1d984

media/libeffects/dynamicsproc/aidl/DynamicsProcessing.cpp

+4 −0
Original line number Diff line number Diff line
@@ -215,6 +215,10 @@ ndk::ScopedAStatus DynamicsProcessingImpl::open(const Parameter::Common& common, 
    RETURN_OK_IF(mState != State::INIT);

    mImplContext = createContext(common);

    RETURN_IF(!mContext || !mImplContext, EX_NULL_POINTER, "createContextFailed");

    int version = 0;

    RETURN_IF(!getInterfaceVersion(&version).isOk(), EX_UNSUPPORTED_OPERATION,

              "FailedToGetInterfaceVersion");

    mImplContext->setVersion(version);

    mEventFlag = mImplContext->getStatusEventFlag();



    if (specific.has_value()) {

media/libeffects/visualizer/aidl/Visualizer.cpp

+2 −2
Original line number Diff line number Diff line
@@ -61,8 +61,8 @@ const std::vector<Range::VisualizerRange> VisualizerImpl::kRanges = { 
        MAKE_RANGE(Visualizer, latencyMs, 0, VisualizerContext::kMaxLatencyMs),

        MAKE_RANGE(Visualizer, captureSamples, 0, VisualizerContext::kMaxCaptureBufSize),

        /* get only parameters, set invalid range (min > max) to indicate not support set */

        MAKE_RANGE(Visualizer, measurement, Visualizer::Measurement({.peak = 1, .rms = 1}),

                   Visualizer::Measurement({.peak = 0, .rms = 0})),

        MAKE_RANGE(Visualizer, measurement, Visualizer::Measurement({.rms = 1, .peak = 1}),

                   Visualizer::Measurement({.rms = 0, .peak = 0})),

        MAKE_RANGE(Visualizer, captureSampleBuffer, std::vector<uint8_t>({1}),

                   std::vector<uint8_t>({0}))};

const Capability VisualizerImpl::kCapability = {