Commit 1c2234cc authored Mar 06, 2020 by Chih-Hung Hsieh Committed by Chih-hung Hsieh Mar 17, 2020

Fix bugprone-use-after-move warnings

* line 1512:21: warning: std::move of the variable 'order' of the
  trivially-copyable type 'size_t' (aka 'unsigned int')
  has no effect; remove std::move() [performance-move-const-arg]
* line 1512:31: warning: 'order' used after it was moved
  [bugprone-use-after-move]
  note: the use happens in a later loop iteration than the move

Bug: 150783499
Test: WITH_TIDY=1 make
Change-Id: I5c41c63b0dfbb2472ab164166065adb18a615b33

parent b1d2e747

media/libstagefright/xmlparser/MediaCodecsXmlParser.cpp

+1 −1

Original line number	Diff line number	Diff line
		@@ -1509,7 +1509,7 @@ void MediaCodecsXmlParser::Impl::generateRoleMap() const {
		nodeInfo.attributeList.push_back(Attribute{"rank", rank});
		}
		nodeList->insert(std::make_pair(
		std::move(order), std::move(nodeInfo)));
		order, std::move(nodeInfo)));
		}
		}
		}