Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dd9b0c1b authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "Remove allowlist for updatable modules with current min_sdk_version" into main

parents ad2aa3d2 32c93a3f
Loading
Loading
Loading
Loading
+1 −6
Original line number Diff line number Diff line
@@ -2662,18 +2662,13 @@ func (a *apexBundle) checkStaticLinkingToStubLibraries(ctx android.ModuleContext
	})
}

// TODO (b/221087384): Remove this allowlist
var (
	updatableApexesWithCurrentMinSdkVersionAllowlist = []string{"com.android.profiling"}
)

// checkUpdatable enforces APEX and its transitive dep properties to have desired values for updatable APEXes.
func (a *apexBundle) checkUpdatable(ctx android.ModuleContext) {
	if a.Updatable() {
		if a.minSdkVersionValue(ctx) == "" {
			ctx.PropertyErrorf("updatable", "updatable APEXes should set min_sdk_version as well")
		}
		if a.minSdkVersion(ctx).IsCurrent() && !android.InList(ctx.ModuleName(), updatableApexesWithCurrentMinSdkVersionAllowlist) {
		if a.minSdkVersion(ctx).IsCurrent() {
			ctx.PropertyErrorf("updatable", "updatable APEXes should not set min_sdk_version to current. Please use a finalized API level or a recognized in-development codename")
		}
		if a.UsePlatformApis() {