Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 32c93a3f authored by Spandan Das's avatar Spandan Das
Browse files

Remove allowlist for updatable modules with current min_sdk_version 

All existing violations have been cleaned up.

Bug: 221087384
Test: presbumits
Change-Id: Iefe318d9372d4078f21b03e0d9003609cca069ab
parent 0adcc8c8

apex/apex.go

+1 −6
Original line number Diff line number Diff line
@@ -2663,18 +2663,13 @@ func (a *apexBundle) checkStaticLinkingToStubLibraries(ctx android.ModuleContext 
	})

}



// TODO (b/221087384): Remove this allowlist

var (

	updatableApexesWithCurrentMinSdkVersionAllowlist = []string{"com.android.profiling"}

)



// checkUpdatable enforces APEX and its transitive dep properties to have desired values for updatable APEXes.

func (a *apexBundle) checkUpdatable(ctx android.ModuleContext) {

	if a.Updatable() {

		if a.minSdkVersionValue(ctx) == "" {

			ctx.PropertyErrorf("updatable", "updatable APEXes should set min_sdk_version as well")

		}

		if a.minSdkVersion(ctx).IsCurrent() && !android.InList(ctx.ModuleName(), updatableApexesWithCurrentMinSdkVersionAllowlist) {

		if a.minSdkVersion(ctx).IsCurrent() {

			ctx.PropertyErrorf("updatable", "updatable APEXes should not set min_sdk_version to current. Please use a finalized API level or a recognized in-development codename")

		}

		if a.UsePlatformApis() {