Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 01332cf3 authored by Kousik Kumar's avatar Kousik Kumar
Browse files

Move libFlags as well to the RSP file for link actions 

This is to avoid hitting command-line length issues when building with
RBE enabled for C++ links.

TESTED=ran a build with link actions and saw command-line getting
shorter in size from verbose.log
Bug: b/237480728

Change-Id: Id66165159388554bb76579080c5a6979dd670d22
parent 7bc78194

cc/builder.go

+2 −2
Original line number Diff line number Diff line
@@ -63,10 +63,10 @@ var ( 
	ld, ldRE = pctx.RemoteStaticRules("ld",

		blueprint.RuleParams{

			Command: "$reTemplate$ldCmd ${crtBegin} @${out}.rsp " +

				"${libFlags} ${crtEnd} -o ${out} ${ldFlags} ${extraLibFlags}",

				"${crtEnd} -o ${out} ${ldFlags} ${extraLibFlags}",

			CommandDeps:    []string{"$ldCmd"},

			Rspfile:        "${out}.rsp",

			RspfileContent: "${in}",

			RspfileContent: "${in} ${libFlags}",

			// clang -Wl,--out-implib doesn't update its output file if it hasn't changed.

			Restat: true,

		},