Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7bc78194 authored by Kousik Kumar's avatar Kousik Kumar
Browse files

Add a broad warning about missing LOAS creds 

This is to generally warn Google devs about lack of LOAS creds.

Given the switch to RBE, lack of LOAS creds will start resulting in build
failures, so adding a warning message ahead of time to all builds. Will
convert this to a build failure after a week.
We need LOAS creds to be able to even fetch the CDPush config file to
determine whether to use RBE in a build a not, which is why I'm making
this a broad error message across builds.

Test: ran "m nothing" build with / without gcert and with / without
"stubby" in $PATH and confirmed appropriate error message.
Bug: b/235985591

Change-Id: I15cbaf372b0a7b79f868a06c7d5ede19b49ae687
parent dd3ea926

cmd/soong_ui/main.go

+1 −0
Original line number Diff line number Diff line
@@ -221,6 +221,7 @@ func main() { 
		}

		defer build.UploadMetrics(buildCtx, config, c.simpleOutput, buildStarted, files...)

		defer met.Dump(soongMetricsFile)

		defer build.CheckProdCreds(buildCtx, config)

	}



	// Read the time at the starting point.

ui/build/config.go

+30 −0
Original line number Diff line number Diff line
@@ -1242,10 +1242,40 @@ func (c *configImpl) rbeSockAddr(dir string) (string, error) { 
	return "", fmt.Errorf("cannot generate a proxy socket address shorter than the limit of %v", maxNameLen)

}



// IsGooglerEnvironment returns true if the current build is running

// on a Google developer machine and false otherwise.

func (c *configImpl) IsGooglerEnvironment() bool {

	cf := "ANDROID_BUILD_ENVIRONMENT_CONFIG"

	if v, ok := c.environ.Get(cf); ok {

		return v == "googler"

	}

	return false

}



// GoogleProdCredsExist determine whether credentials exist on the

// Googler machine to use remote execution.

func (c *configImpl) GoogleProdCredsExist() bool {

	if _, err := exec.Command("/usr/bin/prodcertstatus", "--simple_output", "--nocheck_loas").Output(); err != nil {

		return false

	}

	return true

}



// UseRemoteBuild indicates whether to use a remote build acceleration system

// to speed up the build.

func (c *configImpl) UseRemoteBuild() bool {

	return c.UseGoma() || c.UseRBE()

}



// StubbyExists checks whether the stubby binary exists on the machine running

// the build.

func (c *configImpl) StubbyExists() bool {

	if _, err := exec.LookPath("stubby"); err != nil {

		return false

	}

	return true

}



// RemoteParallel controls how many remote jobs (i.e., commands which contain

// gomacc) are run in parallel.  Note the parallelism of all other jobs is

// still limited by Parallel()

ui/build/rbe.go

+29 −0
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ import ( 
	"os"

	"path/filepath"

	"runtime"

	"strings"



	"android/soong/ui/metrics"

)
@@ -126,6 +127,34 @@ func stopRBE(ctx Context, config Config) { 
	}

}



func prodCredsAuthType(config Config) bool {

	authVar, val := config.rbeAuth()

	if strings.Contains(authVar, "use_google_prod_creds") && val != "" && val != "false" {

		return true

	}

	return false

}



// Check whether proper auth exists for RBE builds run within a

// Google dev environment.

func CheckProdCreds(ctx Context, config Config) {

	if !config.IsGooglerEnvironment() {

		return

	}

	if !config.StubbyExists() && prodCredsAuthType(config) {

		fmt.Fprintln(ctx.Writer, "")

		fmt.Fprintln(ctx.Writer, fmt.Sprintf("\033[33mWARNING: %q binary not found in $PATH, follow go/build-fast#opting-out-of-loas-credentials instead for authenticating with RBE.\033[0m", "stubby"))

		fmt.Fprintln(ctx.Writer, "")

		return

	}

	if config.GoogleProdCredsExist() {

		return

	}

	fmt.Fprintln(ctx.Writer, "")

	fmt.Fprintln(ctx.Writer, "\033[33mWARNING: Missing LOAS credentials, please run `gcert`. This will result in failing builds in the future, see go/rbe-android-default-announcement.\033[0m")

	fmt.Fprintln(ctx.Writer, "")

}



// DumpRBEMetrics creates a metrics protobuf file containing RBE related metrics.

// The protobuf file is created if RBE is enabled and the proxy service has

// started. The proxy service is shutdown in order to dump the RBE metrics to the