Use -target-feature for MTE
Instead of setting -march, use clang's -target-feature functionality to enable MTE. Some projects set -march which may conflict with MTE's usage. Using -target-feature to enable MTE removes any clang command line ordering issues. History: * Originally submitted as 3340cf27 * reverted in 32721f12 due to bug 371029823 * Prematurely resubmitted as fe67d8f1 and then subsequently reverted in 476da833 as the fix for bug 371029823 had not yet landed. Fixes the following compile failures on _fullmte builds: vendor/google/services/LyricCameraHAL/src/lyric/api/algo/data_types/local_tone_mapping_data_v1.cc vendor/google/services/LyricCameraHAL/src/lyric/api/algo/data_types/local_tone_mapping_data_v1.cc:209:34: error: always_inline function 'vpaddq_f16' requires target feature 'fullfp16', but would be inlined into function 'GridMeanNeon' that is compiled without support for 'fullfp16' 209 | vmulq_f16(norm, vpaddq_f16(vpaddq_f16(slope_bias[0], slope_bias[1]), | ^ vendor/google/services/LyricCameraHAL/src/lyric/api/algo/data_types/local_tone_mapping_data_v1.cc:210:34: error: always_inline function 'vpaddq_f16' requires target feature 'fullfp16', but would be inlined into function 'GridMeanNeon' that is compiled without support for 'fullfp16' 210 | vpaddq_f16(slope_bias[2], slope_bias[3]))); Bug: 366222162 Test: compiles and boots Change-Id: I821b310908dd9ff2aeaa81459762286590337eaf
Loading
Please register or sign in to comment