Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f049389e authored by Wei Li's avatar Wei Li
Browse files

Check if an installed file exists and report error if not. 

So far there is only one case happened in b/277039235 that an installed file in that product is moved to another directory in LOCAL_POST_INSTALL_CMD. The team agreed to convert to Android.bp, but better to add a check and report the error.

Bug: 277039235
Test: m sbom
Test: build/soong/tests/sbom_test.sh
Change-Id: I9a2302ced6dd605e60e54c49a8778426444dcc4f
parent 4ae1b2e2

tools/generate-sbom.py

+10 −5
Original line number Diff line number Diff line
@@ -87,6 +87,7 @@ ISSUE_NO_METADATA = 'No metadata generated in Make for installed files:' 
ISSUE_NO_METADATA_FILE = 'No METADATA file found for installed file:'

ISSUE_METADATA_FILE_INCOMPLETE = 'METADATA file incomplete:'

ISSUE_UNKNOWN_SECURITY_TAG_TYPE = 'Unknown security tag type:'

ISSUE_INSTALLED_FILE_NOT_EXIST = 'Non-exist installed files:'

INFO_METADATA_FOUND_FOR_PACKAGE = 'METADATA file found for packages:'
@@ -601,7 +602,8 @@ def main(): 
    ISSUE_NO_METADATA_FILE: [],

    ISSUE_METADATA_FILE_INCOMPLETE: [],

    ISSUE_UNKNOWN_SECURITY_TAG_TYPE: [],

      INFO_METADATA_FOUND_FOR_PACKAGE: []

    ISSUE_INSTALLED_FILE_NOT_EXIST: [],

    INFO_METADATA_FOUND_FOR_PACKAGE: [],

  }



  # Scan the metadata in CSV file and create the corresponding package and file records in SPDX
@@ -619,6 +621,9 @@ def main(): 


      if not installed_file_has_metadata(installed_file_metadata, report):

        continue

      if not os.path.isfile(installed_file):

        report[ISSUE_INSTALLED_FILE_NOT_EXIST].append(installed_file)

        continue



      file_id = new_file_id(installed_file)

      product_files.append(new_file_record(file_id, installed_file, checksum(installed_file)))