Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3dfd20ae authored by Duane Sand's avatar Duane Sand
Browse files

[MIPS] Temporarily disable Mips shared-textrel errors 

Clang++ for Mips and Mips64 generates read-only exception unwind
tables that trigger DT_TEXTREL warnings at link time.  Until Clang
is fixed, ignore those performance warnings instead of failing the build.

With this patch, Mips clang++ can be (optionally) used when building
libdeqp.

NDK's Mips llvm has been using an alternate temporary fix, marking the
.gcc_exception_table section as read-write for Mips only:
   https://android-review.googlesource.com/#/c/119660/

A permanent fix using a read-only exception table is pending upstream:
   http://reviews.llvm.org/D9669

Change-Id: Ie0cd7da398acbe45dbe39adc251e7fd5b5ca1445
parent 44158945

core/clang/mips.mk

+5 −0
Original line number Diff line number Diff line
@@ -14,6 +14,11 @@ CLANG_CONFIG_mips_UNKNOWN_CFLAGS := \ 
  -msynci \

  -mno-fused-madd



# Temporary workaround for Mips clang++ problem,  creates

#   relocated ptrs in read-only pic .gcc_exception_table;

#   permanent fix pending at http://reviews.llvm.org/D9669

CLANG_CONFIG_mips_UNKNOWN_CFLAGS += -Wl,--warn-shared-textrel



# We don't have any mips flags to substitute yet.

define subst-clang-incompatible-mips-flags

  $(1)

core/clang/mips64.mk

+5 −0
Original line number Diff line number Diff line
@@ -14,6 +14,11 @@ CLANG_CONFIG_mips64_UNKNOWN_CFLAGS := \ 
  -msynci \

  -mno-fused-madd



# Temporary workaround for Mips clang++ problem creating

#   relocated ptrs in read-only pic .gcc_exception_table;

#   permanent fix pending at http://reviews.llvm.org/D9669

CLANG_CONFIG_mips64_UNKNOWN_CFLAGS += -Wl,--warn-shared-textrel



# We don't have any mips64 flags to substitute yet.

define subst-clang-incompatible-mips64-flags

  $(1)