Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 37b5bf8a authored by Lalit Maganti's avatar Lalit Maganti
Browse files

build: enable Perfetto by default 

Perfetto has been enabled by default on Pixel devices since P and has
proved to be stable and helped find performance issues on both P and Q.

On R+, iorapd has a dependency on Perfetto and thus we need to be enabled
by default.

Note that CTS tests have ensured that any downstream consumers of Android
have not accidentally broken Perfetto in old releases so this should be
safe to introduce and maintain going forward.

The two daemons of Perfetto (traced and traced_probes) are located on the
/system partition so for consistency, we have chosen to also enable the
build property on the system partition.

Googlers can see the below link for more context and detailed info.

Change-Id: I00fa7d4c97eda4d0ab83520d0f428bca83707d8a
Context (Googlers only): go/perfetto-by-default
Bug: 137963570
Test: checking product/build.prop in Treehugger builds
parent 11566c2a

target/product/base_system.mk

+1 −0
Original line number Diff line number Diff line
@@ -357,6 +357,7 @@ PRODUCT_COPY_FILES += system/core/rootdir/init.zygote32.rc:system/etc/init/hw/in 
PRODUCT_DEFAULT_PROPERTY_OVERRIDES += ro.zygote=zygote32



PRODUCT_SYSTEM_DEFAULT_PROPERTIES += debug.atrace.tags.enableflags=0

PRODUCT_SYSTEM_DEFAULT_PROPERTIES += persist.traced.enable=1



# Packages included only for eng or userdebug builds, previously debug tagged

PRODUCT_PACKAGES_DEBUG := \

target/product/emulator.mk

+0 −6
Original line number Diff line number Diff line
@@ -50,12 +50,6 @@ $(call inherit-product-if-exists, device/generic/goldfish/vendor.mk) 
#PRODUCT_DEFAULT_PROPERTY_OVERRIDES += \

#config.disable_location=true



# Enable Perfetto traced

# There is a stable property API for this prop so we can move it to /product.

# https://android-review.googlesource.com/c/platform/system/libsysprop/+/952375

PRODUCT_PRODUCT_PROPERTIES += \

    persist.traced.enable=1



# enable Google-specific location features,

# like NetworkLocationProvider and LocationCollector

PRODUCT_SYSTEM_EXT_PROPERTIES += \

target/product/emulator_vendor.mk

+0 −6
Original line number Diff line number Diff line
@@ -42,12 +42,6 @@ $(call inherit-product-if-exists, device/generic/goldfish/vendor.mk) 
#PRODUCT_DEFAULT_PROPERTY_OVERRIDES += \

#config.disable_location=true



# Enable Perfetto traced

# There is a stable property API for this prop so we can move it to /product.

# https://android-review.googlesource.com/c/platform/system/libsysprop/+/952375

PRODUCT_PRODUCT_PROPERTIES += \

    persist.traced.enable=1



# enable Google-specific location features,

# like NetworkLocationProvider and LocationCollector

PRODUCT_SYSTEM_EXT_PROPERTIES += \

target/product/go_defaults_common.mk

+0 −1
Original line number Diff line number Diff line
@@ -20,7 +20,6 @@ 
# Set lowram options and enable traced by default

PRODUCT_PROPERTY_OVERRIDES += \

     ro.config.low_ram=true \

     persist.traced.enable=1 \



# Speed profile services and wifi-service to reduce RAM and storage.

PRODUCT_SYSTEM_SERVER_COMPILER_FILTER := speed-profile