Consider non-shipping lunch targets to be future.
Many places in the codebase have checks like this: if shipping level > X: do cool thing Y This is great because it reduces the cost to upgrade and test old Android devices or refactor their code. However, many targets, such as the NDK, the SDK, mainline modules, and so on do not set a shipping level, so they don't get to do the cool thing Y. In order to resolve this, we could modify every check to check the default case. However, this is an invasive change, and it is not maintainable. Instead, consider non-shipping products to always be in the future. In general, Android features are required to be backwards compatible, so this should always work for things like mainline. Also note, this means when someone adds a new feature Y like this, they'll clearly see the impact of it being added everywhere, rather than on such a small selection of newly shipping devices. This avoids a risk where a change needs to be run on mainline modules (or other targets) but is not tested in this configuration from the start. Future work: many `ifndef` checks can be cleaned up after this, or if this approach makes sense, they can be cleaned up in this CL. Bug: 339026799 Bug: 279808973 Bug: 333908433 Test: builds of: - errorprone-trunk_staging - mainline_modules_sdks-trunk_staging-userdebug - mainline_modules_x86_64-trunk_staging-userdebug - ndk - sdk-trunk_staging-userdebug Test: too large number gives: build/make/core/product_config.mk:598: error: integer greater than 10001 is not supported!. Change-Id: I17c34267f774ea8b9265e1d798a67af7838715c5
Loading
Please register or sign in to comment