Commit 6929e4e5 authored Mar 19, 2024 by Elliott Hughes

Fix connect() retry loop.

This would succeed eventually anyway: the first time round the connect() succeeds, returns 0, and we go around the loop again; the second time the connect() fails (because we're already connected), returns -1, and we set success to true and exit the loop. But this means that the intended retry functionality is broken.

Change-Id: If631d59e23b12e9aa952cdb528160b19b9a94b1c

parent b70699b8

tests/unit/uncrypt_test.cpp

+1 −1

Original line number	Diff line number	Diff line
		@@ -96,7 +96,7 @@ class UncryptTest : public ::testing::Test {
		// Connect to the uncrypt socket.
		bool success = false;
		for (int retry = 0; retry < SOCKET_CONNECTION_MAX_RETRY; retry++) {
		if (connect(sockfd, reinterpret_cast<sockaddr*>(&un), sizeof(sockaddr_un)) != 0) {
		if (connect(sockfd, reinterpret_cast<sockaddr*>(&un), sizeof(sockaddr_un)) == 0) {
		success = true;
		break;
		}