Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Draft: 5842: use GMS FusedLoc to fix real loc endless loading

Guillaume Jacquart requested to merge 5842-use_gms_fused_location into main

Description

e/backlog#5842 (comment 284356)

A new attempt to fix the Real location endless loading on FakeLocation Screen. We use the Google-Play-services (GMS) FusedLocationProvider (implemented by microG in /e/) to retrieve the location, and workaround the bugs in AOSP LocationManager.

As mentioned in the issue , the behavior looks better : fix may take a few X * 10secondes, but, gps icon doesn't disapears with this method.

But how could we be convinced that adding a dependency on com.google.android.gms:play-services-location will not bring some leaks toward google?

Screenshots

Technical details

Tests

<Explain here the test scenarios that have been done for the feature, including corner cases.>

Issues

e/backlog#5842 (comment 284356)

10 commandments of code reviews

<Keep the link above in the merge request description to remind the 10 commandments to the reviewers.>

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/development/code-review

Edited by Guillaume Jacquart

Merge request reports

Loading