Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

fix:3514: Avoid switching output country when Tor is running.

Guillaume Jacquart requested to merge 3514-fix_switch_output_country into main

Description

I found a bug in current main branch:

  1. Activate IpScrambling
  2. Go to Manage Ipscrambling screen, and change out put country
  3. Then the Device can't resolve DNS, and any web request fail.

I didn't find root cause of this bug. Most likely it is related to the recent update of Orbot (but I'm surprised to observed it just now, I did another fix arount the select country feature at that occasion...). As a quick workaround, I blocked the change of exit country while Tor is ON, and add a little tooltip to inform the user about it.

@aude is it ok for you ?

Screenshots

Screenshot_20250924-173155_Advanced_Privacy

Technical details

Tests

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/3514

10 commandments of code review

👪 ❤️ https://gitlab.e.foundation/groups/e/-/wikis/contribute/development-processes/code-review-guidelines

Summary by CodeRabbit

  • New Features
    • Added a tooltip guiding users to disable “Hide my real IP address” before changing location.
    • Updated the location label to include an asterisk indicator.
    • Location selector now becomes enabled only when IP masking is turned off.
    • Added/updated translations for the tooltip and label across English, German, Spanish, French, Italian, Finnish, and Dutch.
Edited by CodeRabbitAI

Merge request reports

Loading