Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

fix:sentry-OOM: Fix leaks on binding object.

Guillaume Jacquart requested to merge 0-remove_memory_leaks into main

Description

Fix leaks of Databinding instances on Fragments, using the recommended pattern : https://developer.android.com/topic/libraries/view-binding#fragments This work had been done a while ago by Abhishek but I didn't follow the pattern since.

Hope that it could avoid future OOM errors like this one : https://murena-sas.sentry.io/issues/6694774887/?project=4504355889938432&query=is%3Aunresolved&referrer=issue-stream&stream_index=2

Issues

10 commandments of code review

👪 ❤️ https://gitlab.e.foundation/groups/e/-/wikis/contribute/development-processes/code-review-guidelines

Summary by CodeRabbit

  • Bug Fixes
    • Improved app stability and memory usage by updating several screens to better manage resources when navigating away, reducing the risk of memory leaks. No visible changes to features or user interface.
Edited by CodeRabbitAI

Merge request reports