Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Draft: tech:2995: Add Debug Tools Activity only on Debug builds

Guillaume Jacquart requested to merge 2995-debug_activity into main

Description

Some features will execute just weekly. It's not handy for debugging. To allow easier debuging and a first step of NRT on these features, this MR add a debug Activity (only in debug build) on top of AdvancedPrivacy. This activity will be upgraded will debug views over time.

Technical details

To have a module not included in the release, but able to access easily all the classes of the main module, I had to

  • move all the app module into the new advancedprivacy module
  • create a new app module, which would add the new APDebugTools module only on debug build.

This introduce a lot of "move file" changes, real changes only concern the APDebugTools module, and biuld.gradle, manifest.xml on advanedprivacy and app modules.

If anyone has a lighter solution in mind, he's welcome 😄
edit: Maybe just a feature flag (I have to check how they work), but the debug code will be shipped in this case, good for QA test, but a risk to ship more bug :/

Tests

  • Tested all the assembleEos jobs
  • Installed all builds on a tests device
  • Didn't validate the full release process, with an real /e/OS image build (no issue expected, but it would good to double check before next beta - during ABI split apk tests for example).

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/2995

10 commandments of code reviews

👪 ❤️ https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Edited by Guillaume Jacquart

Merge request reports

Loading